Merge pull request #2 from biplobsd/main

Argument for specifying .spec file to build

README.md

@@ -1,2 +1,76 @@
-# pyinstaller-action
- Github Action for building executables with Pyinstaller
+# PyInstaller-Action-Windows
+
+Github Action for building executables with PyInstaller
+
+To build your application, you need to specify where your source code is via the `path` argument, this defaults to `src`.
+
+The source code directory should have your `.spec` file that PyInstaller generates. If you don't have one, you'll need to run PyInstaller once locally to generate it.
+Also if you have another program `.spec` file you can set specific pyinstaller `.spec` file by `spec: <YOUR_SPEC_FILE_NAME>`
+
+If the `src` folder has a `requirements.txt` file, the packages will be installed into the environment before PyInstaller runs.
+
+If you wish to specify a package mirror, this is possibly via the `pypi_url` and/or the `pypi_index_url`, these defaults are:
+
+- `pypi_url` = `https://pypi.python.org/`
+- `pypi_index_url` = `https://pypi.python.org/simple`
+
+> If you are using the default Python `gitignore` file, ensure to remove `.spec`.
+
+> This action uses [Wine](https://www.winehq.org) to emulate windows inside Docker for packaging POSIX executables.
+
+## Example usage
+
+There's an example repository where you can see this action in action: <https://github.com/JackMcKew/pyinstaller-action-windows-example>. Where you can find the packaged executable at: <https://github.com/JackMcKew/pyinstaller-action-windows-example/actions/runs/135879475>.
+
+Include this in your `.github/workflows/main.yaml`:
+
+```yaml
+- name: PyInstaller Windows
+  uses: JackMcKew/pyinstaller-action-windows@main
+    with:
+      path: src
+```
+
+## Full Example
+
+Here is an entire workflow for:
+
+- Packaging an application with PyInstaller
+- Uploading the packaged executable as an artifact
+
+``` yaml
+
+name: Package Application with Pyinstaller
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Package Application
+      uses: JackMcKew/pyinstaller-action-windows@main
+      with:
+        path: src
+
+    - uses: actions/upload-artifact@v2
+      with:
+        name: name-of-artifact
+        path: src/dist/windows
+```
+
+## FAQ
+
+If you get this error: `OSError: [WinError 123] Invalid name: '/tmp\\*'`, ensure your path is correctly configured, the default is `src`.
+
+## Sources
+
+A big thank you to all the contributors over at <https://github.com/cdrx/docker-pyinstaller>, this action is just a modified version of their docker container, thank you!

action.yml

@@ -6,9 +6,21 @@ branding:
   color: 'blue'
 inputs:
   path:
-    description: 'Directory containing source code & .spec file (optional requirements.txt).'
+    description: 'Directory containing source code (optional requirements.txt).'
     required: True
-    default: src/
+    default: src
+  pypi_url:
+    description: 'Specify a custom URL for PYPI'
+    required: False
+    default: https://pypi.python.org/
+  pypi_index_url:
+    description: 'Specify a custom URL for PYPI Index'
+    required: False
+    default: https://pypi.python.org/simple
+  spec:
+    description: 'Specify a file path for .spec file'
+    required: False
+    default: ""
 outputs:
   output:
     description: 'The output of PyInstaller'
@@ -18,3 +30,6 @@ runs:
   image: 'Dockerfile'
   args:
     - ${{ inputs.path }}
+    - ${{ inputs.pypi_url }}
+    - ${{ inputs.pypi_index_url }}
+    - ${{ inputs.spec }}

entrypoint.sh

@@ -9,9 +9,18 @@ set -e
 # Allow the workdir to be set using an env var.
 # Useful for CI pipiles which use docker for their build steps
 # and don't allow that much flexibility to mount volumes
-SRCDIR="github/workspace/"$1
+SRCDIR=$1
+
+PYPI_URL=$2
+
+PYPI_INDEX_URL=$3
+
 WORKDIR=${SRCDIR:-/src}
 
+SPEC_FILE=${4:-*.spec}
+
+python -m pip install --upgrade pip wheel setuptools
+
 #
 # In case the user specified a custom URL for PYPI, then use
 # that one, instead of the default one.
@@ -36,11 +45,11 @@ if [ -f requirements.txt ]; then
     pip install -r requirements.txt
 fi # [ -f requirements.txt ]
 
-echo "$@"
 
-if [[ "$@" == "" ]]; then
-    pyinstaller --clean -y --dist ./dist/windows --workpath /tmp *.spec
-    chown -R --reference=. ./dist/windows
-else
-    sh -c "$@"
-fi # [[ "$@" == "" ]]
+
+# if [[ "$@" == "" ]]; then
+pyinstaller --clean -y --dist ./dist/windows --workpath /tmp $SPEC_FILE
+chown -R --reference=. ./dist/windows
+# else
+    # sh -c "$@"
+# fi # [[ "$@" == "" ]]